[WIP] Allow various StdLib protocols: ~Copyable #85079
Draft
+1,977
−1,548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
slavapestov
reviewed
Oct 23, 2025
|
Love it. Ship it. |
airspeedswift
force-pushed
the
equate-no-copy
branch
from
30dac0a to
3313de1
Compare
|
@swift-ci please test |
stephentyrone
approved these changes
Oct 24, 2025
| let _ = x < 2 // expected-error {{value of optional type 'Int?' must be unwrapped to a value of type 'Int'}} | ||
| // expected-note@-1 {{coalesce using '??' to provide a default when the optional value contains 'nil'}} {{12-12= ?? <#default value#>}} | ||
| // expected-note@-2 {{force-unwrap using '!' to abort execution if the optional value contains 'nil'}} {{12-12=!}} | ||
| let _ = x < 2 // expected-error {{binary operator '<' cannot be applied to operands of type 'Int?' and 'Int'}} |
There was a problem hiding this comment.
It looks like there's some dedicated diagnostic that we're no longer getting here, but I'm not sure how much value it was adding to begin with.
There was a problem hiding this comment.
yeah tbh I feel like the newer diagnostic is better
airspeedswift
force-pushed
the
equate-no-copy
branch
from
d20e485 to
e0b3ecd
Compare
|
@swift-ci please smoke test |
airspeedswift
force-pushed
the
equate-no-copy
branch
from
e0b3ecd to
510c0b8
Compare
airspeedswift
changed the title
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Equatable: ~Copyable. First step towards makingEquatable,ComparableandHashablenoncopyable and nonescapable compliant.